Issue 389333003: Leftover cleanups from https://codereview.chromium.org/324493002 .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389333003: Leftover cleanups from https://codereview.chromium.org/324493002 . (Closed)

Created:
6 years, 5 months ago by erikwright (departed)

Modified:
6 years, 5 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Leftover cleanups from https://codereview.chromium.org/324493002 . Moves one more method from PersistentPrefStore to WritablePrefStore. This allows most "writing" operations to be possible without the more complex PersistentPrefStore API. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282967

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	base/prefs/persistent_pref_store.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/prefs/value_map_pref_store.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/prefs/value_map_pref_store.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/prefs/writeable_pref_store.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

The changes from https://codereview.chromium.org/331433002/ were accidentally committed in https://codereview.chromium.org/324493002 even though they were not required ...

6 years, 5 months ago (2014-07-14 13:37:18 UTC) #1

erikwright (departed)

The CQ bit was checked by erikwright@chromium.org

6 years, 5 months ago (2014-07-14 16:46:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/389333003/1

6 years, 5 months ago (2014-07-14 16:47:48 UTC) #4

Message was sent while issue was closed.

Change committed as 282967

Expand Messages | Collapse Messages