Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 389313003: Fix races in DeviceLocalAccountTest.Extensions* (Closed)

Created:
6 years, 5 months ago by bartfab (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix races in DeviceLocalAccountTest.Extensions* The DeviceLocalAccountTest.Extensions* assumed that extensions get copied to an account's cache after successful installation. In reality, extensions are downloaded to the cache at first and then removed again if installation fails. The removal happens asynchronously on a background thread. This led to a race where tests would try to verify that an extension does not exist in a cache without waiting for the removal process to finish first. This CL switches the tests from verifying that an extension has been removed from disk to checking whether the cache entry has been removed, which happens synchronously on the UI thread. BUG=393208 TEST=DeviceLocalAccountTest.Extensions* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285070

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 4 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bartfab (slow)
Hi Dmitry, Could you review please? Hi Zel, Could you do an owner review for: ...
6 years, 5 months ago (2014-07-14 12:55:42 UTC) #1
Dmitry Polukhin
lgtm
6 years, 5 months ago (2014-07-14 14:43:45 UTC) #2
bartfab (slow)
Hi Toni, I am having no luck reaching Zel. Could you do an owner review ...
6 years, 5 months ago (2014-07-23 08:30:17 UTC) #3
Dmitry Polukhin
lgtm
6 years, 5 months ago (2014-07-23 09:34:51 UTC) #4
tbarzic
On 2014/07/23 09:34:51, Dmitry Polukhin wrote: lgtm
6 years, 5 months ago (2014-07-23 15:18:18 UTC) #5
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 5 months ago (2014-07-23 15:20:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/389313003/20001
6 years, 5 months ago (2014-07-23 15:21:23 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 17:12:51 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 17:33:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173846)
6 years, 5 months ago (2014-07-23 17:33:12 UTC) #10
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 5 months ago (2014-07-23 17:40:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/389313003/20001
6 years, 5 months ago (2014-07-23 17:42:00 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 22:59:41 UTC) #13
Message was sent while issue was closed.
Change committed as 285070

Powered by Google App Engine
This is Rietveld 408576698