Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 389283005: Add restart_masters.py (Closed)

Created:
6 years, 5 months ago by borenet
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Add restart_masters.py I got a little sick of watching the masters restart this morning, so I decided to write this helper script. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/a14cfe2961d9003adc79f2110d5b5d2ca2239cc3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
A scripts/restart_masters.py View 1 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
6 years, 5 months ago (2014-07-14 15:27:27 UTC) #1
rmistry
LGTM https://codereview.chromium.org/389283005/diff/1/scripts/restart_masters.py File scripts/restart_masters.py (right): https://codereview.chromium.org/389283005/diff/1/scripts/restart_masters.py#newcode68 scripts/restart_masters.py:68: pid = get_running_pid(master) This would be clearer to ...
6 years, 5 months ago (2014-07-14 20:27:17 UTC) #2
borenet
https://codereview.chromium.org/389283005/diff/1/scripts/restart_masters.py File scripts/restart_masters.py (right): https://codereview.chromium.org/389283005/diff/1/scripts/restart_masters.py#newcode68 scripts/restart_masters.py:68: pid = get_running_pid(master) On 2014/07/14 20:27:16, rmistry wrote: > ...
6 years, 5 months ago (2014-07-14 20:35:04 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 5 months ago (2014-07-14 20:35:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/389283005/20001
6 years, 5 months ago (2014-07-14 20:35:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 20:36:03 UTC) #6
Message was sent while issue was closed. 
Change committed as a14cfe2961d9003adc79f2110d5b5d2ca2239cc3

Powered by Google App Engine
This is Rietveld 408576698