Issue 389263007: Update <#include> file order for Issue 340393003.

Issue 389263007: Update <#include> file order for Issue 340393003. (Closed)

Created:
6 years, 5 months ago by Xi Han

Modified:
6 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update <#include> file order. Initial patch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283310

Patch Set 2 : updates #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
M	chrome/browser/plugins/plugin_info_message_filter.cc	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.cc	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Xi Han

Please see the updates. Sorry for missing your last comment of issue 340393003.

6 years, 5 months ago (2014-07-14 18:53:04 UTC) #1

jam

lgtm with nits https://codereview.chromium.org/389263007/diff/20001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (right): https://codereview.chromium.org/389263007/diff/20001/chrome/browser/plugins/plugin_info_message_filter.cc#newcode34 chrome/browser/plugins/plugin_info_message_filter.cc:34: #if defined(ENABLE_EXTENSIONS) nit: sort it with ...

6 years, 5 months ago (2014-07-15 00:39:49 UTC) #2

Xi Han

https://codereview.chromium.org/389263007/diff/20001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (right): https://codereview.chromium.org/389263007/diff/20001/chrome/browser/plugins/plugin_info_message_filter.cc#newcode34 chrome/browser/plugins/plugin_info_message_filter.cc:34: #if defined(ENABLE_EXTENSIONS) On 2014/07/15 00:39:49, jam wrote: > nit: ...

6 years, 5 months ago (2014-07-15 14:17:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/389263007/40001

6 years, 5 months ago (2014-07-15 14:25:41 UTC) #5

Message was sent while issue was closed.

Change committed as 283310

Expand Messages | Collapse Messages