Docserver: Fix missing samples in some API reference pages

Docserver: Fix missing samples in some API reference pages

BUG=309814
R=kalman
NOTRY=TRUE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231169

[not at google - send to devlin, 2013-10-24 20:27:54]

lgtm

https://chromiumcodereview.appspot.com/38923003/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/38923003/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:202: break
thanks for this fix. It can be much simpler:

try:
  return [call['name'] for call in sample['api_calls']
          if call['name'].startswith(api_name + '.')]
except NotImplementedError:
  return []

though that bug looks fixed; maybe you don't need the try/except either.

[方觉(Fang Jue), 2013-10-25 00:59:46]

https://chromiumcodereview.appspot.com/38923003/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/38923003/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:202: break
On 2013/10/24 20:27:54, kalman wrote:
> thanks for this fix. It can be much simpler:
> 
> try:
>   return [call['name'] for call in sample['api_calls']
>           if call['name'].startswith(api_name + '.')]
> except NotImplementedError:
>   return []

It's not actually correct but I got what you meant. I inlined everything as a
single return statement.

> 
> though that bug looks fixed; maybe you don't need the try/except either.

It is fixed. I also looked at other files and it seems that NotImplementedError
shouldn't be raised here so I removed the try/except.

[commit-bot: I haz the power, 2013-10-26 00:34:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/38923003/60001

[commit-bot: I haz the power, 2013-10-26 00:42:36]

Change committed as 231169