Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 389223002: Cleanup: Remove unnecessary uses of direct_dependent_settings. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unnecessary uses of direct_dependent_settings. build/grit_target.gypi does this for us, clients/consumers just need to define grit_out_dir variable and include grit_target.gypi for the magic happen. Found these entries with the following command line: $ for f in $(g ls-files | grep resources.gyp); do grep direct $f; echo $f; done $ for f in $(g ls-files | grep strings.gyp); do grep direct $f; echo $f; done BUG=None TEST=None TBR=keybuk@chromium.org,yoz@chromium.org,darin@chromium.org keybuk for device/bluetooth/ yoz for extensions/ darin for webkit/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283646

Patch Set 1 #

Patch Set 2 : bluetooth fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M device/bluetooth/bluetooth_strings.gyp View 1 1 chunk +3 lines, -8 lines 0 comments Download
M extensions/extensions_resources.gyp View 2 chunks +2 lines, -8 lines 0 comments Download
M webkit/webkit_resources.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...(please, rubber stamp?). Thanks!
6 years, 5 months ago (2014-07-14 02:23:46 UTC) #1
keybuk
On 2014/07/14 02:23:46, tfarina wrote: > TBRing...(please, rubber stamp?). > > Thanks! lgtm
6 years, 5 months ago (2014-07-14 19:26:36 UTC) #2
Yoyo Zhou
LGTM for extensions resources
6 years, 5 months ago (2014-07-15 02:24:02 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-17 00:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/389223002/20001
6 years, 5 months ago (2014-07-17 00:28:46 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:59:11 UTC) #6
Message was sent while issue was closed.
Change committed as 283646

Powered by Google App Engine
This is Rietveld 408576698