Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 389193002: Fix condition of FileReader::hasPendingActivity (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
Reviewers:
haraken, tzik, inferno
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Project:
blink
Visibility:
Public.

Description

Fix condition of FileReader::hasPendingActivity Before this patch, |hasPendingActiviy| checked |m_loadingState| to check if it is stopped. However, when called |abort()|, FileReader schedules a delayed task to call |doAbort()|, while setting |m_loadingState| to |LoadingStateAborted|. This may cause the FileReader to go away when |doAbort()| is called. This patch avoids the issue by having |hasPendingActivity| look at |m_state| instead. BUG=393425 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178019

Patch Set 1 #

Patch Set 2 : add layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
A LayoutTests/fast/files/file-reader-abort-gc.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/fast/files/file-reader-abort-gc-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
6 years, 5 months ago (2014-07-14 00:27:58 UTC) #1
haraken
Would you give me a permission to see the bug? Also add more to the ...
6 years, 5 months ago (2014-07-14 00:34:55 UTC) #2
blink-reviews
Adding a LayoutTest now. Please hold on review. On Mon, Jul 14, 2014 at 9:34 ...
6 years, 5 months ago (2014-07-14 00:37:41 UTC) #3
kouhei (in TOK)
Updated description and added a test. PTAL.
6 years, 5 months ago (2014-07-14 00:54:19 UTC) #4
haraken
LGTM
6 years, 5 months ago (2014-07-14 01:06:56 UTC) #5
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-14 01:07:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/389193002/20001
6 years, 5 months ago (2014-07-14 01:07:54 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 01:55:00 UTC) #8
Message was sent while issue was closed.
Change committed as 178019

Powered by Google App Engine
This is Rietveld 408576698