Source/platform/weborigin/SchemeRegistry.h - Issue 389053003: Always report access control failure if accessing unsupported URL.

Side by Side Diff: Source/platform/weborigin/SchemeRegistry.h

Issue 389053003: Always report access control failure if accessing unsupported URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Include supported schemes in console error message Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/loader/DocumentThreadableLoader.cpp ('k') | Source/platform/weborigin/SchemeRegistry.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71	71

72 // Schemes against which javascript: URLs should not be allowed to run (stop	72 // Schemes against which javascript: URLs should not be allowed to run (stop

73 // bookmarklets from running on sensitive pages).	73 // bookmarklets from running on sensitive pages).

74 static void registerURLSchemeAsNotAllowingJavascriptURLs(const String& schem e);	74 static void registerURLSchemeAsNotAllowingJavascriptURLs(const String& schem e);

75 static bool shouldTreatURLSchemeAsNotAllowingJavascriptURLs(const String& sc heme);	75 static bool shouldTreatURLSchemeAsNotAllowingJavascriptURLs(const String& sc heme);

76	76

77 // Allow non-HTTP schemes to be registered to allow CORS requests.	77 // Allow non-HTTP schemes to be registered to allow CORS requests.

78 static void registerURLSchemeAsCORSEnabled(const String& scheme);	78 static void registerURLSchemeAsCORSEnabled(const String& scheme);

79 static bool shouldTreatURLSchemeAsCORSEnabled(const String& scheme);	79 static bool shouldTreatURLSchemeAsCORSEnabled(const String& scheme);

80	80

	81 // Serialize the registered schemes in a comma-separated list.

	82 static String listOfCORSEnabledURLSchemes();
	tyoshino (SeeGerritForStatus) 2014/07/14 07:14:01 [optional] start with a verb? buildListOf... [optional] start with a verb? buildListOf... sof 2014/07/14 08:20:41 thanks, will wait on abarth's feedback before rena Show quoted text On 2014/07/14 07:14:01, tyoshino wrote: > [optional] start with a verb? buildListOf... thanks, will wait on abarth's feedback before renaming. abarth-chromium 2014/07/14 16:51:51 Using a noun phrase is fine. We're not instructin Using a noun phrase is fine. We're not instructing the SchemeRegistry to do anything. We're just asking for the listOfCORSEnabledURLSchemes.
	83

81 // Allow resources from some schemes to load on a page, regardless of its	84 // Allow resources from some schemes to load on a page, regardless of its

82 // Content Security Policy.	85 // Content Security Policy.

83 static void registerURLSchemeAsBypassingContentSecurityPolicy(const String& scheme);	86 static void registerURLSchemeAsBypassingContentSecurityPolicy(const String& scheme);

84 static void removeURLSchemeRegisteredAsBypassingContentSecurityPolicy(const String& scheme);	87 static void removeURLSchemeRegisteredAsBypassingContentSecurityPolicy(const String& scheme);

85 static bool schemeShouldBypassContentSecurityPolicy(const String& scheme);	88 static bool schemeShouldBypassContentSecurityPolicy(const String& scheme);

86 };	89 };

87	90

88 } // namespace WebCore	91 } // namespace WebCore

89	92

90 #endif // SchemeRegistry_h	93 #endif // SchemeRegistry_h

OLD	NEW