Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: runtime/vm/object_store.cc

Issue 388963003: Avoid allocating an exception object in the snapshot reader. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_store.cc
===================================================================
--- runtime/vm/object_store.cc (revision 38227)
+++ runtime/vm/object_store.cc (working copy)
@@ -132,6 +132,11 @@
return false;
}
set_out_of_memory(Instance::Cast(result));
+
+ const UnhandledException& unhandled_exception = UnhandledException::Handle(
+ UnhandledException::New(Instance::Cast(result), Instance::Handle()));
siva 2014/07/16 01:00:13 maybe add a comment here that the preallocated unh
Florian Schneider 2014/07/16 11:15:42 Done.
+ set_preallocated_unhandled_exception(unhandled_exception);
+
const Array& code_array = Array::Handle(
isolate,
Array::New(Stacktrace::kPreallocatedStackdepth, Heap::kOld));

Powered by Google App Engine
This is Rietveld 408576698