runtime/vm/object.h - Issue 388963003: Avoid allocating an exception object in the snapshot reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 388963003: Avoid allocating an exception object in the snapshot reader. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 38227)

+++ runtime/vm/object.h (working copy)

@@ -4171,11 +4171,14 @@

virtual const char* ToErrorCString() const;

private:

+ static RawUnhandledException* New(Heap::Space space = Heap::kNew);

siva 2014/07/16 01:00:13 Where is this new 'New' function used? I could not

Florian Schneider 2014/07/16 11:15:42 Yes, it's used in the macro NEW_OBJECT macro.

void set_exception(const Instance& exception) const;

void set_stacktrace(const Instance& stacktrace) const;

FINAL_HEAP_OBJECT_IMPLEMENTATION(UnhandledException, Error);

friend class Class;

+ friend class ObjectStore;

};

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')