Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: runtime/vm/snapshot.h

Issue 388963003: Avoid allocating an exception object in the snapshot reader. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.h
===================================================================
--- runtime/vm/snapshot.h (revision 38227)
+++ runtime/vm/snapshot.h (working copy)
@@ -67,6 +67,7 @@
class RawTypeParameter;
class RawTypeArguments;
class RawTwoByteString;
+class RawUnhandledException;
class RawUnresolvedClass;
class String;
class TokenStream;
@@ -248,7 +249,6 @@
Array* TokensHandle() { return &tokens_; }
TokenStream* StreamHandle() { return &stream_; }
ExternalTypedData* DataHandle() { return &data_; }
- UnhandledException* ErrorHandle() { return &error_; }
// Reads an object.
RawObject* ReadObject();
@@ -299,6 +299,7 @@
RawFloat64x2* NewFloat64x2(double v0, double v1);
RawApiError* NewApiError();
RawLanguageError* NewLanguageError();
+ RawUnhandledException* NewUnhandledException();
RawObject* NewInteger(int64_t value);
RawStacktrace* NewStacktrace();
@@ -389,6 +390,7 @@
friend class TypeParameter;
friend class TypeRef;
friend class UnresolvedClass;
+ friend class UnhandledException;
friend class WeakProperty;
friend class MirrorReference;
DISALLOW_COPY_AND_ASSIGN(SnapshotReader);
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698