Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/json_schema_compiler/test/crossref_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/crossref_unittest.cc
diff --git a/tools/json_schema_compiler/test/crossref_unittest.cc b/tools/json_schema_compiler/test/crossref_unittest.cc
index df91b2d29a123e08d4782d75963e73626c445c7d..05f3096134ccbee733a0bf2b621878baf8f03aff 100644
--- a/tools/json_schema_compiler/test/crossref_unittest.cc
+++ b/tools/json_schema_compiler/test/crossref_unittest.cc
@@ -15,8 +15,7 @@ static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
base::DictionaryValue* value(new base::DictionaryValue());
value->SetWithoutPathExpansion("number", base::Value::CreateDoubleValue(1.1));
value->SetWithoutPathExpansion("integer", base::Value::CreateIntegerValue(4));
- value->SetWithoutPathExpansion("string",
- base::Value::CreateStringValue("bling"));
+ value->SetWithoutPathExpansion("string", new base::StringValue("bling"));
value->SetWithoutPathExpansion("boolean",
base::Value::CreateBooleanValue(true));
return scoped_ptr<base::DictionaryValue>(value);
@@ -103,8 +102,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
scoped_ptr<base::ListValue> params_value(new base::ListValue());
scoped_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
- param_object_value->Set("testType",
- base::Value::CreateStringValue("invalid"));
+ param_object_value->Set("testType", new base::StringValue("invalid"));
param_object_value->Set("boolean", base::Value::CreateBooleanValue(true));
params_value->Append(param_object_value.release());
scoped_ptr<TestTypeInObject::Params> params(

Powered by Google App Engine
This is Rietveld 408576698