Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: components/pref_registry/pref_registry_syncable.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/pref_registry/pref_registry_syncable.cc
diff --git a/components/pref_registry/pref_registry_syncable.cc b/components/pref_registry/pref_registry_syncable.cc
index 675b30915529723ab0a679211ce2c9874f18a8dc..d305b3303ea453c2b4f55c679aee195d3705cdc7 100644
--- a/components/pref_registry/pref_registry_syncable.cc
+++ b/components/pref_registry/pref_registry_syncable.cc
@@ -44,7 +44,7 @@ base::Value* CreateLocaleDefaultValue(base::Value::Type type,
}
case base::Value::TYPE_STRING: {
- return base::Value::CreateStringValue(resource_string);
+ return new base::StringValue(resource_string);
}
default: {
@@ -101,19 +101,16 @@ void PrefRegistrySyncable::RegisterDoublePref(const char* path,
void PrefRegistrySyncable::RegisterStringPref(const char* path,
const std::string& default_value,
PrefSyncStatus sync_status) {
- RegisterSyncablePreference(path,
- base::Value::CreateStringValue(default_value),
- sync_status);
+ RegisterSyncablePreference(
+ path, new base::StringValue(default_value), sync_status);
}
void PrefRegistrySyncable::RegisterFilePathPref(
const char* path,
const base::FilePath& default_value,
PrefSyncStatus sync_status) {
- RegisterSyncablePreference(path,
- base::Value::CreateStringValue(
- default_value.value()),
- sync_status);
+ RegisterSyncablePreference(
+ path, new base::StringValue(default_value.value()), sync_status);
}
void PrefRegistrySyncable::RegisterListPref(const char* path,
@@ -189,7 +186,7 @@ void PrefRegistrySyncable::RegisterInt64Pref(
PrefSyncStatus sync_status) {
RegisterSyncablePreference(
path,
- base::Value::CreateStringValue(base::Int64ToString(default_value)),
+ new base::StringValue(base::Int64ToString(default_value)),
sync_status);
}
@@ -199,7 +196,7 @@ void PrefRegistrySyncable::RegisterUint64Pref(
PrefSyncStatus sync_status) {
RegisterSyncablePreference(
path,
- base::Value::CreateStringValue(base::Uint64ToString(default_value)),
+ new base::StringValue(base::Uint64ToString(default_value)),
sync_status);
}

Powered by Google App Engine
This is Rietveld 408576698