Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_device_client.cc
diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc
index bb26d8acb9b59bd52063616b1d53f5db1bea46b4..de352b1314e96b98f7189b219f23763b56109ad7 100644
--- a/chromeos/dbus/fake_shill_device_client.cc
+++ b/chromeos/dbus/fake_shill_device_client.cc
@@ -242,18 +242,15 @@ void FakeShillDeviceClient::AddDevice(const std::string& device_path,
AddDevice(device_path);
base::DictionaryValue* properties = GetDeviceProperties(device_path);
- properties->SetWithoutPathExpansion(shill::kTypeProperty,
- base::Value::CreateStringValue(type));
- properties->SetWithoutPathExpansion(shill::kNameProperty,
- base::Value::CreateStringValue(name));
- properties->SetWithoutPathExpansion(
- shill::kDBusObjectProperty, base::Value::CreateStringValue(device_path));
- properties->SetWithoutPathExpansion(
- shill::kDBusServiceProperty,
- base::Value::CreateStringValue(modemmanager::kModemManager1ServiceName));
+ properties->SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ properties->SetStringWithoutPathExpansion(shill::kNameProperty, name);
+ properties->SetStringWithoutPathExpansion(shill::kDBusObjectProperty,
+ device_path);
+ properties->SetStringWithoutPathExpansion(
+ shill::kDBusServiceProperty, modemmanager::kModemManager1ServiceName);
if (type == shill::kTypeCellular) {
- properties->SetWithoutPathExpansion(shill::kCellularAllowRoamingProperty,
- new base::FundamentalValue(false));
+ properties->SetBooleanWithoutPathExpansion(
+ shill::kCellularAllowRoamingProperty, false);
}
}

Powered by Google App Engine
This is Rietveld 408576698