Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2542)

Unified Diff: chrome/browser/search_engines/template_url_service_test_util.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_test_util.cc
diff --git a/chrome/browser/search_engines/template_url_service_test_util.cc b/chrome/browser/search_engines/template_url_service_test_util.cc
index 73b412a65c6de741aaec7e3375e1311204f4e49b..62e0cd21c57a76380c107f630a0b5f4a2645bda4 100644
--- a/chrome/browser/search_engines/template_url_service_test_util.cc
+++ b/chrome/browser/search_engines/template_url_service_test_util.cc
@@ -160,18 +160,15 @@ void TemplateURLServiceTestUtilBase::SetManagedDefaultSearchPreferences(
EXPECT_FALSE(keyword.empty());
EXPECT_FALSE(search_url.empty());
- value->Set(DefaultSearchManager::kShortName,
- base::Value::CreateStringValue(name));
- value->Set(DefaultSearchManager::kKeyword,
- base::Value::CreateStringValue(keyword));
- value->Set(DefaultSearchManager::kURL,
- base::Value::CreateStringValue(search_url));
+ value->Set(DefaultSearchManager::kShortName, new base::StringValue(name));
+ value->Set(DefaultSearchManager::kKeyword, new base::StringValue(keyword));
+ value->Set(DefaultSearchManager::kURL, new base::StringValue(search_url));
value->Set(DefaultSearchManager::kSuggestionsURL,
- base::Value::CreateStringValue(suggest_url));
+ new base::StringValue(suggest_url));
value->Set(DefaultSearchManager::kFaviconURL,
- base::Value::CreateStringValue(icon_url));
+ new base::StringValue(icon_url));
value->Set(DefaultSearchManager::kSearchTermsReplacementKey,
- base::Value::CreateStringValue(search_terms_replacement_key));
+ new base::StringValue(search_terms_replacement_key));
std::vector<std::string> encodings_items;
base::SplitString(encodings, ';', &encodings_items);
@@ -185,7 +182,7 @@ void TemplateURLServiceTestUtilBase::SetManagedDefaultSearchPreferences(
scoped_ptr<base::ListValue> alternate_url_list(new base::ListValue());
if (!alternate_url.empty())
- alternate_url_list->Append(base::Value::CreateStringValue(alternate_url));
+ alternate_url_list->Append(new base::StringValue(alternate_url));
value->Set(DefaultSearchManager::kAlternateURLs,
alternate_url_list.release());

Powered by Google App Engine
This is Rietveld 408576698