Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2348)

Unified Diff: chrome/browser/prefs/chrome_pref_service_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/chrome_pref_service_unittest.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc
index 704dcf0557c3b48165a5ad389080d8e16368f267..74860b71dfbbe22f182aa161496e8918c662c6a3 100644
--- a/chrome/browser/prefs/chrome_pref_service_unittest.cc
+++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc
@@ -101,7 +101,7 @@ class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {
TestingPrefServiceSyncable* pref_services =
profile()->GetTestingPrefService();
pref_services->SetUserPref(prefs::kDefaultCharset,
- base::Value::CreateStringValue("utf8"));
+ new base::StringValue("utf8"));
pref_services->SetUserPref(prefs::kWebKitDefaultFontSize,
base::Value::CreateIntegerValue(20));
pref_services->SetUserPref(prefs::kWebKitTextAreasAreResizable,
@@ -109,7 +109,7 @@ class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {
pref_services->SetUserPref(prefs::kWebKitUsesUniversalDetector,
base::Value::CreateBooleanValue(true));
pref_services->SetUserPref("webkit.webprefs.foo",
- base::Value::CreateStringValue("bar"));
+ new base::StringValue("bar"));
}
};

Powered by Google App Engine
This is Rietveld 408576698