Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_browsertest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_browsertest.cc
diff --git a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
index 658926a27e489b561a55d4e602a0c5789eae9cc4..f92774556112796dd1cfbff887acbdebebd724c6 100644
--- a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
+++ b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
@@ -138,9 +138,11 @@ std::string GetTestPolicy(const char* homepage, int key_version) {
void GetExpectedDefaultPolicy(PolicyMap* policy_map) {
#if defined(OS_CHROMEOS)
- policy_map->Set(
- key::kChromeOsMultiProfileUserBehavior, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateStringValue("primary-only"), NULL);
+ policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
sky 2014/07/11 22:54:47 nit: I tend to think imposing your favorite style
Evan Stade 2014/07/11 22:56:27 I actually just ran the file (and all files in thi
+ POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER,
+ new base::StringValue("primary-only"),
+ NULL);
#endif
}
@@ -158,13 +160,17 @@ void GetExpectedTestPolicy(PolicyMap* expected, const char* homepage) {
expected->Set(
key::kMaxInvalidationFetchDelay, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, base::Value::CreateIntegerValue(1000), NULL);
- expected->Set(
- key::kHomepageLocation, POLICY_LEVEL_RECOMMENDED,
- POLICY_SCOPE_USER, base::Value::CreateStringValue(homepage), NULL);
+ expected->Set(key::kHomepageLocation,
+ POLICY_LEVEL_RECOMMENDED,
+ POLICY_SCOPE_USER,
+ new base::StringValue(homepage),
+ NULL);
#if defined(OS_CHROMEOS)
- expected->Set(
- key::kChromeOsMultiProfileUserBehavior, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateStringValue("primary-only"), NULL);
+ expected->Set(key::kChromeOsMultiProfileUserBehavior,
+ POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER,
+ new base::StringValue("primary-only"),
+ NULL);
#endif
}
« no previous file with comments | « chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698