components/policy/core/common/preg_parser_win.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/preg_parser_win.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/preg_parser_win.cc

diff --git a/components/policy/core/common/preg_parser_win.cc b/components/policy/core/common/preg_parser_win.cc

index 6a8b19a3202a5fe678ded6669cbbefcbce616745..16fc0becb31ff205d1e7c27c3aedb9a110ce6bc2 100644

--- a/components/policy/core/common/preg_parser_win.cc

+++ b/components/policy/core/common/preg_parser_win.cc

@@ -118,7 +118,7 @@ bool DecodePRegValue(uint32 type,

switch (type) {

case REG_SZ:

case REG_EXPAND_SZ:

- value->reset(base::Value::CreateStringValue(DecodePRegStringValue(data)));

+ value->reset(new base::StringValue(DecodePRegStringValue(data)));

return true;

case REG_DWORD_LITTLE_ENDIAN:

case REG_DWORD_BIG_ENDIAN: