Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/background/background_application_list_model_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_application_list_model_unittest.cc
diff --git a/chrome/browser/background/background_application_list_model_unittest.cc b/chrome/browser/background/background_application_list_model_unittest.cc
index a8c817942175bad9553120e77c7882b0c8544e9b..81da6eb618144d78d167ad34db58548954ee32de 100644
--- a/chrome/browser/background/background_application_list_model_unittest.cc
+++ b/chrome/browser/background/background_application_list_model_unittest.cc
@@ -81,11 +81,11 @@ static scoped_refptr<Extension> CreateExtensionBase(
base::ListValue* permissions = new base::ListValue();
manifest.Set(extensions::manifest_keys::kPermissions, permissions);
if (background_permission) {
- permissions->Append(base::Value::CreateStringValue("background"));
+ permissions->Append(new base::StringValue("background"));
}
if (push_messaging == PUSH_MESSAGING_PERMISSION ||
push_messaging == PUSH_MESSAGING_BUT_NOT_BACKGROUND) {
- permissions->Append(base::Value::CreateStringValue("pushMessaging"));
+ permissions->Append(new base::StringValue("pushMessaging"));
}
std::string error;
« no previous file with comments | « cc/resources/tile_priority.cc ('k') | chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698