Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 388913005: [SyncFS] Migrate ServiceMetadata from MDDB to MDDBIndex. (Closed)

Created:
6 years, 5 months ago by peria
Modified:
6 years, 5 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Migrate ServiceMetadata from MDDB to MDDBIndex. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabase*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283491

Patch Set 1 : #

Patch Set 2 : Remove usage of undefined variable #

Total comments: 3

Patch Set 3 : Rebase and work for nits #

Total comments: 2

Patch Set 4 : Work for a nit #

Total comments: 2

Patch Set 5 : Work for nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -81 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 2 3 4 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 2 11 chunks +13 lines, -55 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 4 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 1 2 3 4 4 chunks +54 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 2 3 4 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
peria
PTL.
6 years, 5 months ago (2014-07-15 03:57:19 UTC) #1
tzik
looks good overall https://codereview.chromium.org/388913005/diff/60001/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc (right): https://codereview.chromium.org/388913005/diff/60001/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc#newcode225 chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:225: index->Initialize(scoped_ptr<ServiceMetadata>(new ServiceMetadata), contents); can be make_scoped_ptr? ...
6 years, 5 months ago (2014-07-15 07:17:58 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/388913005/diff/100001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc File chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc (right): https://codereview.chromium.org/388913005/diff/100001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc#newcode196 chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc:196: batch->Put(kServiceMetadataKey, value); Is it necessary to put the ...
6 years, 5 months ago (2014-07-15 07:47:21 UTC) #3
peria
https://codereview.chromium.org/388913005/diff/60001/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc (right): https://codereview.chromium.org/388913005/diff/60001/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc#newcode460 chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:460: return kInvalidTrackerID; On 2014/07/15 07:17:58, tzik wrote: > could ...
6 years, 5 months ago (2014-07-15 09:00:58 UTC) #4
tzik
https://codereview.chromium.org/388913005/diff/120001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc File chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc (right): https://codereview.chromium.org/388913005/diff/120001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc#newcode25 chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc:25: leveldb::WriteBatch* batch) { Can we add if (!batch)return; here ...
6 years, 5 months ago (2014-07-15 13:55:46 UTC) #5
peria
https://codereview.chromium.org/388913005/diff/120001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc File chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc (right): https://codereview.chromium.org/388913005/diff/120001/chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc#newcode25 chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc:25: leveldb::WriteBatch* batch) { On 2014/07/15 13:55:45, tzik wrote: > ...
6 years, 5 months ago (2014-07-16 02:08:51 UTC) #6
tzik
lgtm
6 years, 5 months ago (2014-07-16 02:27:11 UTC) #7
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-16 02:28:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/388913005/140001
6 years, 5 months ago (2014-07-16 02:32:15 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 20:36:49 UTC) #10
Message was sent while issue was closed. 
Change committed as 283491

Powered by Google App Engine
This is Rietveld 408576698