Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 388913004: evaluateScriptInMainWorld() should check if the target context exists before evaluating a script (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

evaluateScriptInMainWorld() should check if the target context exists before evaluating a script This is a speculative fix of bug 393137 (I cannot reproduce it). It's possible that evaluateScriptInMainWorld() is called in a state where toV8Context(m_frame, mainWorld()) returns NULL. For example, this can happen when the m_frame is already detached from the window object (but I don't figure out the exact call path that causes the issue). Either way, evaluateScriptInMainWorld() should check if the target context exists or not before starting evaluating a script. This CL makes the change. BUG=393137 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-14 09:43:26 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-14 09:53:37 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-14 09:54:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/388913004/1
6 years, 5 months ago (2014-07-14 09:55:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-14 10:57:10 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 11:55:48 UTC) #6
Message was sent while issue was closed.
Change committed as 178047

Powered by Google App Engine
This is Rietveld 408576698