Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: runtime/vm/assembler_ia32_test.cc

Issue 388863002: Better sequences for class id loading on ia32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_ia32_test.cc
===================================================================
--- runtime/vm/assembler_ia32_test.cc (revision 38158)
+++ runtime/vm/assembler_ia32_test.cc (working copy)
@@ -3073,14 +3073,34 @@
ASSEMBLER_TEST_RUN(ConditionalMovesEqual, test) {
- typedef int (*ConditionalMovesSignCode)(int i);
- int res = reinterpret_cast<ConditionalMovesSignCode>(test->entry())(785);
+ typedef int (*ConditionalMovesEqualCode)(int i);
+ int res = reinterpret_cast<ConditionalMovesEqualCode>(test->entry())(785);
EXPECT_EQ(1, res);
- res = reinterpret_cast<ConditionalMovesSignCode>(test->entry())(-12);
+ res = reinterpret_cast<ConditionalMovesEqualCode>(test->entry())(-12);
EXPECT_EQ(0, res);
}
+// Return 1 if not equal, 0 if equal.
+ASSEMBLER_TEST_GENERATE(ConditionalMovesNotEqual, assembler) {
+ __ xorl(EAX, EAX);
+ __ movl(ECX, Immediate(1));
+ __ movl(EDX, Address(ESP, 1 * kWordSize));
+ __ cmpl(EDX, Immediate(785));
+ __ cmovne(EAX, ECX);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(ConditionalMovesNotEqual, test) {
+ typedef int (*ConditionalMovesNotEqualCode)(int i);
+ int res = reinterpret_cast<ConditionalMovesNotEqualCode>(test->entry())(785);
+ EXPECT_EQ(0, res);
+ res = reinterpret_cast<ConditionalMovesNotEqualCode>(test->entry())(-12);
+ EXPECT_EQ(1, res);
+}
+
+
ASSEMBLER_TEST_GENERATE(ConditionalMovesCompare, assembler) {
__ movl(EDX, Immediate(1)); // Greater equal.
__ movl(ECX, Immediate(-1)); // Less

Powered by Google App Engine
This is Rietveld 408576698