base_unittests_run

Add the required xvfb testing tool to the isolate target for some tests.

Missing from base_unit_tests, unit_tests and browser_tests.

TBR=brettw@chromium.org
R=maruel@chromium.org, brettw@chromium.org
BUG=None
TEST=local clean ; gyp ; build ; run isolate for base

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283063

[M-A Ruel, 2014-07-11 16:09:08]

https://codereview.chromium.org/388843004/diff/1/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/388843004/diff/1/base/base.gyp#newcode1503
base/base.gyp:1503: ]
],

https://codereview.chromium.org/388843004/diff/1/base/base.gyp#newcode1504
base/base.gyp:1504: }, {
Remove this line.

[Peter Mayo, 2014-07-11 17:23:02]

Done.

This should be driven by isolate_dependency_tracked, not a per target extension.

[M-A Ruel, 2014-07-11 17:42:00]

On 2014/07/11 17:23:02, Peter Mayo wrote:
> Done.
> 
> This should be driven by isolate_dependency_tracked, not a per target
extension.

I don't understand what "This" references to.

lgtm in any case.

[Peter Mayo, 2014-07-11 17:51:42]

I mean I don't think I should add the dendency to the particular target
isolate, but to the rule that generates the .isolates that use the
framework that references it.


On 11 July 2014 13:42, <maruel@chromium.org> wrote:

> On 2014/07/11 17:23:02, Peter Mayo wrote:
>
>> Done.
>>
>
>  This should be driven by isolate_dependency_tracked, not a per target
>>
> extension.
>
> I don't understand what "This" references to.
>
> lgtm in any case.
>
> https://codereview.chromium.org/388843004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Mayo, 2014-07-11 17:59:32]

It turns out what I see as the complete/accurate sultion is commented out
in the isolate.gypi with an explanatiuon of deferal.


On 11 July 2014 13:51, Peter Mayo <petermayo@chromium.org> wrote:

> I mean I don't think I should add the dendency to the particular target
> isolate, but to the rule that generates the .isolates that use the
> framework that references it.
>
>
> On 11 July 2014 13:42, <maruel@chromium.org> wrote:
>
>> On 2014/07/11 17:23:02, Peter Mayo wrote:
>>
>>> Done.
>>>
>>
>>  This should be driven by isolate_dependency_tracked, not a per target
>>>
>> extension.
>>
>> I don't understand what "This" references to.
>>
>> lgtm in any case.
>>
>> https://codereview.chromium.org/388843004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Mayo, 2014-07-11 18:02:39]

This should be repeated for 
./chrome/browser_tests.isolate
./chrome/sync_integration_tests.isolate
./chrome/interactive_ui_tests.isolate
./chrome/unit_tests.isolate
./base/base_unittests.isolate
./content/content_unittests.isolate

Which also all reference this executable.

[Peter Mayo, 2014-07-11 18:19:56]

https://codereview.chromium.org/388843004/diff/40001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/388843004/diff/40001/base/base.gyp#newcode1500
base/base.gyp:1500: ['use_x11 == 1', {
This is a more accurate test I found in some of the other targets.

https://codereview.chromium.org/388843004/diff/40001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/388843004/diff/40001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:2904: ['use_x11 == 1', {
e.g. here.

[M-A Ruel, 2014-07-11 18:48:06]

lgtm, thanks a lot

[Peter Mayo, 2014-07-11 18:50:30]

+brettw for OWNERS

[brettw, 2014-07-14 19:18:36]

lgtm

[Peter Mayo, 2014-07-14 19:50:34]

The CQ bit was checked by petermayo@chromium.org

[commit-bot: I haz the power, 2014-07-14 19:51:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/petermayo@chromium.org/388843004/40001

[commit-bot: I haz the power, 2014-07-14 22:47:16]

Change committed as 283063