Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: include/core/SkPicture.h

Issue 388833003: Remove Skia's use of the default SkPicture constructor and multi-clone (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/skia_for_android_framework_defines.gypi ('k') | src/core/SkPicture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index 362f80642d12f4c6840fea03b8a9b1023bd8aef9..db996e02e87fa4c29384e6ed0c1e27a7ba608753 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -63,7 +63,9 @@ public:
typedef SkRefCnt INHERITED;
};
+#ifdef SK_SUPPORT_LEGACY_DEFAULT_PICTURE_CTOR
SkPicture();
+#endif
/** PRIVATE / EXPERIMENTAL -- do not call */
void EXPERIMENTAL_addAccelData(const AccelData*) const;
@@ -112,13 +114,6 @@ public:
* Creates a thread-safe clone of the picture that is ready for playback.
*/
SkPicture* clone() const;
-
- /**
- * Creates multiple thread-safe clones of this picture that are ready for
- * playback. The resulting clones are stored in the provided array of
- * SkPictures.
- */
- void clone(SkPicture* pictures, int count) const;
#endif
/** Replays the drawing commands on the specified canvas.
@@ -244,8 +239,8 @@ private:
void needsNewGenID() { fUniqueID = SK_InvalidGenID; }
- // Create a new SkPicture from an existing SkPictureData. Ref count of
- // data is unchanged.
+ // Create a new SkPicture from an existing SkPictureData. The new picture
+ // takes ownership of 'data'.
SkPicture(SkPictureData* data, int width, int height);
SkPicture(int width, int height, const SkPictureRecord& record, bool deepCopyOps);
« no previous file with comments | « gyp/skia_for_android_framework_defines.gypi ('k') | src/core/SkPicture.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698