Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on.

Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on, by modifying (or adding) YouTube's PrefCookie in the HTTP header.

This is essentially a followup to https://codereview.chromium.org/11186002/

Note: This is a fixed reland of crrev.com/282546 / https://codereview.chromium.org/354183002/ which was reverted due to a bug in ParseRequestCookieLine.

TBRing since it has already been reviewed in the first try.

TBR=erikwright@chromium.org

BUG=344815
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284687

[Marc Treib, 2014-07-14 15:31:20]

Let's try this again.
The previous CL was reverted due to a bug in ParseRequestCookieLine that caused
an invalid iterator dereference. Only the Win dbg bot caught it, and that one
isn't run by the CQ...
I've marked the fix below; everything else is identical to the previous CL.

https://codereview.chromium.org/388823002/diff/20001/net/cookies/cookie_util.cc
File net/cookies/cookie_util.cc (right):

https://codereview.chromium.org/388823002/diff/20001/net/cookies/cookie_util....
net/cookies/cookie_util.cc:231: if (i != header_value.end() && i + 1 !=
header_value.end()) {
The previous version only checked for "i != header_value.end()" and thus did not
handle "key=", i.e. the case where there is an equal sign but no value.

[battre, 2014-07-15 10:51:06]

lgtm

[Marc Treib, 2014-07-22 10:52:42]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:53:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/treib@chromium.org/388823002/40001

[commit-bot: I haz the power, 2014-07-22 12:45:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 16:03:27]

Change committed as 284687

[Joao da Silva, 2014-09-10 10:12:44]

joaodasilva@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[Joao da Silva, 2014-09-10 10:12:45]

This changed the semantics of an existing policy. Please CC the enterprise team
whenever the semantics of a pref controlled by policy is changed.

[Marc Treib, 2014-09-10 10:54:47]

On 2014/09/10 10:12:45, Joao da Silva wrote:
> This changed the semantics of an existing policy. Please CC the enterprise
team
> whenever the semantics of a pref controlled by policy is changed.

Sorry about that, I didn't know. I will do that in the future if it happens to
come up again.