Add per-item animations to the menu

Add per-item animations to the menu

- Animate the normal menu items down into the menu while fading in.
- Animate the icon row to the left while fading in.

BUG=394898
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284781

[David Trainor- moved to gerrit, 2014-07-11 22:55:46]

ptal.  Not going to land this quite yet because I'm not 100% happy with the
timings (feels like it takes too long).  Will work with UX to see if we can
shorten the animations a bit.  I also will probably land the cubic bezier
interpolator and the popup-level animations first.

[aurimas (slooooooooow), 2014-07-15 01:37:26]

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/r...
File chrome/android/java/res/values/ids.xml (right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/r...
chrome/android/java/res/values/ids.xml:3: <!-- Copyright (c) 2014 The Chromium
Authors. All rights reserved.
Remove (c)

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:294:
ViewGroup list = mPopup.getListView();
Should we be animating the views that are currently not visible?

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:121:
convertView.setTag(holder);
Should we set a key for this tag? I am not sure how getTag() works below if you
set multiple tags.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:256:
private Animator buildStandardItemEnterAnimator(final View view, int position) {
Please add some comments to these animator constructors that explain what kind
of animation will be produced.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:317:
return ObjectAnimator.ofFloat(view, View.ALPHA, 1.f, 0.f).setDuration(0);
What does it mean to have an animation of length 0?

[David Trainor- moved to gerrit, 2014-07-15 20:53:39]

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/r...
File chrome/android/java/res/values/ids.xml (right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/r...
chrome/android/java/res/values/ids.xml:3: <!-- Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/07/15 01:37:25, aurimas wrote:
> Remove (c)

Done.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:294:
ViewGroup list = mPopup.getListView();
On 2014/07/15 01:37:25, aurimas wrote:
> Should we be animating the views that are currently not visible?

This will animate all the views that are currently added to the layout (which
leaves it up to the ListView to determine what to add/what is visible).  This
actually ends up only being the visible views.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:121:
convertView.setTag(holder);
On 2014/07/15 01:37:25, aurimas wrote:
> Should we set a key for this tag? I am not sure how getTag() works below if
you
> set multiple tags.

We don't need one.  getTag()/setTag(Object) store to mTag internally. 
getTag(int)/setTag(int, Object) store to mKeyedTags internally.  I could change
this if you want though.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:256:
private Animator buildStandardItemEnterAnimator(final View view, int position) {
On 2014/07/15 01:37:26, aurimas wrote:
> Please add some comments to these animator constructors that explain what kind
> of animation will be produced.

Will do.

https://chromiumcodereview.appspot.com/388803006/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:317:
return ObjectAnimator.ofFloat(view, View.ALPHA, 1.f, 0.f).setDuration(0);
On 2014/07/15 01:37:26, aurimas wrote:
> What does it mean to have an animation of length 0?

It means right now they just hide immediately.  But that might be tweaked.  Also
it was simpler to have hide/show use the same general codepath to tweak the
views when showing/hiding.

[aurimas (slooooooooow), 2014-07-16 17:03:43]

lgtm

https://codereview.chromium.org/388803006/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://codereview.chromium.org/388803006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:121:
convertView.setTag(holder);
On 2014/07/15 20:53:38, David Trainor wrote:
> On 2014/07/15 01:37:25, aurimas wrote:
> > Should we set a key for this tag? I am not sure how getTag() works below if
> you
> > set multiple tags.
> 
> We don't need one.  getTag()/setTag(Object) store to mTag internally. 
> getTag(int)/setTag(int, Object) store to mKeyedTags internally.  I could
change
> this if you want though.

Acknowledged.

https://codereview.chromium.org/388803006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:317:
return ObjectAnimator.ofFloat(view, View.ALPHA, 1.f, 0.f).setDuration(0);
On 2014/07/15 20:53:38, David Trainor wrote:
> On 2014/07/15 01:37:26, aurimas wrote:
> > What does it mean to have an animation of length 0?
> 
> It means right now they just hide immediately.  But that might be tweaked. 
Also
> it was simpler to have hide/show use the same general codepath to tweak the
> views when showing/hiding.

Acknowledged.

[David Trainor- moved to gerrit, 2014-07-22 21:26:17]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:28:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtrainor@chromium.org/388803006/90001

[commit-bot: I haz the power, 2014-07-22 21:30:19]

Change committed as 284781