Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 388803003: [Mac] Replace SetOverlayView with AllowOtherViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased, fixed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 8 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
9 #include "chrome/browser/devtools/devtools_toggle_action.h" 9 #include "chrome/browser/devtools/devtools_toggle_action.h"
10 #include "chrome/browser/devtools/devtools_ui_bindings.h" 10 #include "chrome/browser/devtools/devtools_ui_bindings.h"
11 #include "content/public/browser/web_contents_delegate.h" 11 #include "content/public/browser/web_contents_delegate.h"
12 #include "content/public/browser/web_contents_observer.h" 12 #include "content/public/browser/web_contents_observer.h"
13 13
14 class Browser; 14 class Browser;
15 class BrowserWindow; 15 class BrowserWindow;
16 class DevToolsControllerTest;
17 class DevToolsEventForwarder; 16 class DevToolsEventForwarder;
18 17
19 namespace content { 18 namespace content {
20 class DevToolsAgentHost; 19 class DevToolsAgentHost;
21 struct NativeWebKeyboardEvent; 20 struct NativeWebKeyboardEvent;
22 class RenderViewHost; 21 class RenderViewHost;
23 } 22 }
24 23
25 namespace user_prefs { 24 namespace user_prefs {
26 class PrefRegistrySyncable; 25 class PrefRegistrySyncable;
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 174
176 // Returns true if devtools window would like to hook beforeunload event 175 // Returns true if devtools window would like to hook beforeunload event
177 // of this |contents|. 176 // of this |contents|.
178 static bool NeedsToInterceptBeforeUnload(content::WebContents* contents); 177 static bool NeedsToInterceptBeforeUnload(content::WebContents* contents);
179 178
180 // Notify devtools window that closing of |contents| was cancelled 179 // Notify devtools window that closing of |contents| was cancelled
181 // by user. 180 // by user.
182 static void OnPageCloseCanceled(content::WebContents* contents); 181 static void OnPageCloseCanceled(content::WebContents* contents);
183 182
184 private: 183 private:
185 friend class DevToolsControllerTest;
186 friend class DevToolsSanityTest; 184 friend class DevToolsSanityTest;
187 friend class BrowserWindowControllerTest; 185 friend class BrowserWindowControllerTest;
188 186
189 // DevTools lifecycle typically follows this way: 187 // DevTools lifecycle typically follows this way:
190 // - Toggle/Open: client call; 188 // - Toggle/Open: client call;
191 // - Create; 189 // - Create;
192 // - ScheduleShow: setup window to be functional, but not yet show; 190 // - ScheduleShow: setup window to be functional, but not yet show;
193 // - DocumentOnLoadCompletedInMainFrame: frontend loaded; 191 // - DocumentOnLoadCompletedInMainFrame: frontend loaded;
194 // - SetIsDocked: frontend decided on docking state; 192 // - SetIsDocked: frontend decided on docking state;
195 // - OnLoadCompleted: ready to present frontend; 193 // - OnLoadCompleted: ready to present frontend;
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 base::Closure load_completed_callback_; 319 base::Closure load_completed_callback_;
322 320
323 base::TimeTicks inspect_element_start_time_; 321 base::TimeTicks inspect_element_start_time_;
324 scoped_ptr<DevToolsEventForwarder> event_forwarder_; 322 scoped_ptr<DevToolsEventForwarder> event_forwarder_;
325 323
326 friend class DevToolsEventForwarder; 324 friend class DevToolsEventForwarder;
327 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 325 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
328 }; 326 };
329 327
330 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 328 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698