Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2092)

Unified Diff: Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js

Issue 388793002: DevTools: Calculate number of warnings and errors and listen for pause in all targets (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js
diff --git a/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js b/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js
index 5acc9e223fd02659fd4866086949c478601194a8..8b87ccbca9370efb2025dd01dc15bfe9733313b9 100644
--- a/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js
+++ b/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js
@@ -136,7 +136,7 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {
for (var i = 0; i < messages.length; i++) {
var message = messages[i];
var rawLocation = this._rawLocation(message);
- if (script.scriptId === rawLocation.scriptId)
+ if (rawLocation && script.scriptId === rawLocation.scriptId)
vsevik 2014/07/11 12:37:03 Why is this needed? I don't think rawLocation coul
sergeyv 2014/07/11 17:21:41 Done.
this._addConsoleMessageToScript(message, rawLocation);
else
pendingMessages.push(message);
« no previous file with comments | « Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698