Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 388793002: DevTools: Calculate number of warnings and errors and listen for pause in all targets (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Calculate number of warnings and errors and listen for pause in all targets BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178041

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address vsevik's comment #

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -27 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 2 5 chunks +88 lines, -24 lines 0 comments Download
M Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-11 09:26:42 UTC) #1
vsevik
https://codereview.chromium.org/388793002/diff/20001/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js File Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js (right): https://codereview.chromium.org/388793002/diff/20001/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js#newcode139 Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js:139: if (rawLocation && script.scriptId === rawLocation.scriptId) Why is this ...
6 years, 5 months ago (2014-07-11 12:37:03 UTC) #2
sergeyv
https://codereview.chromium.org/388793002/diff/20001/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js File Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js (right): https://codereview.chromium.org/388793002/diff/20001/Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js#newcode139 Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js:139: if (rawLocation && script.scriptId === rawLocation.scriptId) On 2014/07/11 12:37:03, ...
6 years, 5 months ago (2014-07-11 17:21:41 UTC) #3
vsevik
lgtm
6 years, 5 months ago (2014-07-13 20:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/388793002/40001
6 years, 5 months ago (2014-07-13 20:48:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-13 21:33:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-13 21:34:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28024)
6 years, 5 months ago (2014-07-13 21:34:53 UTC) #8
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-14 07:48:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/388793002/40001
6 years, 5 months ago (2014-07-14 07:49:00 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-14 07:59:56 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 08:01:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28129)
6 years, 5 months ago (2014-07-14 08:01:10 UTC) #13
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-14 08:04:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/388793002/60001
6 years, 5 months ago (2014-07-14 08:04:19 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-14 09:07:44 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 10:11:35 UTC) #17
Message was sent while issue was closed.
Change committed as 178041

Powered by Google App Engine
This is Rietveld 408576698