Do not expose all timer events to the API callback.

Do not expose all timer events to the API callback.

R=fmeawad@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22422

[Yang, 2014-07-11 13:59:08]

On 2014/07/11 10:44:49, Yang wrote:

I'm not entirely happy about this though. The filter of events is in V8. But I
would argue that it should be the embedder who filters out events that are not
interesting. To do that, I would have to export the list of possible event types
to the API, so that the callback installed by chrome can use it to filter out
uninteresting events.

[fmeawad, 2014-07-16 07:13:39]

On 2014/07/11 13:59:08, Yang wrote:
> On 2014/07/11 10:44:49, Yang wrote:
> 
> I'm not entirely happy about this though. The filter of events is in V8. But I
> would argue that it should be the embedder who filters out events that are not
> interesting. To do that, I would have to export the list of possible event
types
> to the API, so that the callback installed by chrome can use it to filter out
> uninteresting events.

LGTM

(Sorry the delay, the email notification got lost)

[fmeawad, 2014-07-16 07:16:26]

On 2014/07/16 07:13:39, fmeawad-cr wrote:
> On 2014/07/11 13:59:08, Yang wrote:
> > On 2014/07/11 10:44:49, Yang wrote:
> > 
> > I'm not entirely happy about this though. The filter of events is in V8. But
I
> > would argue that it should be the embedder who filters out events that are
not
> > interesting. To do that, I would have to export the list of possible event
> types
> > to the API, so that the callback installed by chrome can use it to filter
out
> > uninteresting events.
> 
> LGTM
> 
> (Sorry the delay, the email notification got lost)

I agree with having the filter implemented in the embedder,
We have a proposal to add all the tracing API in v8, and that would include the
categories as well as the "disabled-*" by default categories. Will work on it
starting from next week.

[Yang, 2014-07-16 08:15:13]

Committed patchset #2 manually as r22422 (presubmit successful).