Some cleanup in PipelineTest.

Some cleanup in PipelineTest.

Do not call Pipeline::On{Audio|Video}RendererEnded() because it's pipeline's
implementation detail and will go away. Instead, let the mock renderers call the
ended_cb.

Also rename several helper functions to reflect what they really do.

BUG=392259
TEST=All current tests pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282798

[xhwang, 2014-07-11 08:11:46]

PTAL

[scherkus (not reviewing), 2014-07-11 19:22:52]

looks good -- just one thought

https://codereview.chromium.org/388763003/diff/1/media/base/pipeline_unittest.cc
File media/base/pipeline_unittest.cc (right):

https://codereview.chromium.org/388763003/diff/1/media/base/pipeline_unittest...
media/base/pipeline_unittest.cc:144: void
ExpectToInitializeDemuxer(MockDemuxerStreamVector* streams,
suggestion: in the PipelineTeardownTests I used "SetXXXExpectations()"

I don't mind but picking one would be good

[xhwang, 2014-07-11 20:35:41]

comments addressed

[xhwang, 2014-07-11 20:36:04]

Thanks for the suggestion. PTAL again!

https://codereview.chromium.org/388763003/diff/1/media/base/pipeline_unittest.cc
File media/base/pipeline_unittest.cc (right):

https://codereview.chromium.org/388763003/diff/1/media/base/pipeline_unittest...
media/base/pipeline_unittest.cc:144: void
ExpectToInitializeDemuxer(MockDemuxerStreamVector* streams,
On 2014/07/11 19:22:52, scherkus wrote:
> suggestion: in the PipelineTeardownTests I used "SetXXXExpectations()"
> 
> I don't mind but picking one would be good

Done.

[scherkus (not reviewing), 2014-07-11 20:53:29]

lgtm

[xhwang, 2014-07-11 20:58:43]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-07-11 21:01:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/388763003/20001

[commit-bot: I haz the power, 2014-07-12 04:50:15]

Change committed as 282798