Reland "Dynamically pick build directory on the slave side."

Reland "Dynamically pick build directory on the slave side."

This was reviewed at https://codereview.chromium.org/31543002 and is identical
to what is there, but since that review landed and got reverted three times
already, I'm landing it under a different review URL now.

The previous attempts caused the following issues:

1. The chrome/android bots on the main waterfall got confused. r229993 / r230044
   addressed this.
1b The android trybots on the webrtc waterfall. r229993 / r230044 will help them
   too.

2. The Blink Testers started testing binaries that weren't built at the right
   revision. That was due to them extracting the binaries into src/build but
   still running layout tests from src/out. This was http://crbug.com/310152
   and should've been fixed by r230280.

3. Some internal chrome/android performance bots broke. This was
   http://crbug.com/310135 and got addressed by internal revisions
   r43584 / r43590

TBR=maruel@chromium.org, iannucci@chromium.org (who reviewed at the original
review URL).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230605

4. It then got reverted once more due to causing stale binaries being used in
   letting local isolate tests (http://crbug.com/311622), which I believe I fixed in
   r231606

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=231610

[commit-bot: I haz the power, 2013-10-24 02:25:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/38873003/1

[commit-bot: I haz the power, 2013-10-24 02:26:30]

Presubmit check for 38873003-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
scripts/slave/unittests/telemetry_test.py failed
FF
======================================================================
FAIL: testExtraArg (__main__.TelemetryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "scripts/slave/unittests/telemetry_test.py", line 125, in testExtraArg
    self.assertEqual(expectedText, self.capture.text)
AssertionError: Lists differ: ["'adb' 'root'", "'adb' 'wait-... != ["'adb'
'root'", "'adb' 'wait-...

First differing element 2:
'/usr/bin/python' '/b/commit-queue/workdir/tools/build/scripts/slave/runtest.py'
'--run-python-script' '--target' 'Release' '--build-dir' 'src/build' '--no-xvfb'
'--factory-properties={"target": "Release", "build_dir": "src/build",
"extra_args": ["--profile-dir=fake_dir"], "perf_id": "android-gn", "step_name":
"sunspider", "test_name": "sunspider", "target_platform": "linux2", "target_os":
"android", "show_perf_results": true}' 'src/tools/perf/run_benchmark' '-v'
'--output-format=buildbot' '--profile-dir=fake_dir'
'--browser=android-chromium-testshell' 'sunspider'
'/usr/bin/python' '/b/commit-queue/workdir/tools/build/scripts/slave/runtest.py'
'--run-python-script' '--target' 'Release' '--build-dir' 'src/out' '--no-xvfb'
'--factory-properties={"target": "Release", "build_dir": "src/build",
"extra_args": ["--profile-dir=fake_dir"], "perf_id": "android-gn", "step_name":
"sunspider", "test_name": "sunspider", "target_platform": "linux2", "target_os":
"android", "show_perf_results": true}' 'src/tools/perf/run_benchmark' '-v'
'--output-format=buildbot' '--profile-dir=fake_dir'
'--browser=android-chromium-testshell' 'sunspider'

Diff is 1597 characters long. Set self.maxDiff to None to see it.

======================================================================
FAIL: testSimpleCommand (__main__.TelemetryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "scripts/slave/unittests/telemetry_test.py", line 93, in
testSimpleCommand
    self.assertEqual(expectedText, self.capture.text)
AssertionError: Lists differ: ["'adb' 'root'", "'adb' 'wait-... != ["'adb'
'root'", "'adb' 'wait-...

First differing element 2:
'/usr/bin/python' '/b/commit-queue/workdir/tools/build/scripts/slave/runtest.py'
'--run-python-script' '--target' 'Release' '--build-dir' 'src/build' '--no-xvfb'
'--factory-properties={"target": "Release", "build_dir": "src/build", "perf_id":
"android-gn", "step_name": "sunspider", "test_name": "sunspider",
"target_platform": "linux2", "target_os": "android", "show_perf_results": true}'
'src/tools/perf/run_benchmark' '-v' '--output-format=buildbot'
'--browser=android-chromium-testshell' 'sunspider'
'/usr/bin/python' '/b/commit-queue/workdir/tools/build/scripts/slave/runtest.py'
'--run-python-script' '--target' 'Release' '--build-dir' 'src/out' '--no-xvfb'
'--factory-properties={"target": "Release", "build_dir": "src/build", "perf_id":
"android-gn", "step_name": "sunspider", "test_name": "sunspider",
"target_platform": "linux2", "target_os": "android", "show_perf_results": true}'
'src/tools/perf/run_benchmark' '-v' '--output-format=buildbot'
'--browser=android-chromium-testshell' 'sunspider'

Diff is 1459 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 2 tests in 1.032s

FAILED (failures=2)


Presubmit checks took 46.0s to calculate.

[commit-bot: I haz the power, 2013-10-24 02:35:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/38873003/50001

[commit-bot: I haz the power, 2013-10-24 02:36:00]

Presubmit check for 38873003-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/masters_test.py failed
1 masters failed:
master.chromium.webrtc.fyi
50 masters succeeded, 1 failed, 1 skipped in 29.7s.

=== Error running master.chromium.webrtc.fyi === 
2013-10-23 19:35:31-0700 [-] WebStatus using
(/b/commit-queue/workdir/tools/build/masters/master.chromium/public_html)
2013-10-23 19:35:31-0700 [-] removing 0 old schedulers, updating 0, and adding
17
2013-10-23 19:35:31-0700 [-] win_periodic_scheduler: missed scheduled build
time, so building immediately
2013-10-23 19:35:32-0700 [-] mac_periodic_scheduler: missed scheduled build
time, so building immediately
2013-10-23 19:35:32-0700 [-] added buildset 1 to database
2013-10-23 19:35:32-0700 [-] added buildset 2 to database
2013-10-23 19:35:32-0700 [-] cros_periodic_scheduler: missed scheduled build
time, so building immediately
2013-10-23 19:35:32-0700 [-] added buildset 3 to database
2013-10-23 19:35:32-0700 [-] android_periodic_scheduler: missed scheduled build
time, so building immediately
2013-10-23 19:35:36-0700 [-] Unhandled Error
	Traceback (most recent call last):
	Failure: twisted.internet.defer.FirstError: FirstError[#0, [Failure instance:
Traceback: <class 'sqlalchemy.exc.OperationalError'>: (OperationalError)
database is locked u'INSERT INTO schedulers (name, state, class_name) VALUES (?,
?, ?)' ('mac_webrtc_trunk_scheduler', '{}',
'buildbot.schedulers.basic.Scheduler')
	/usr/lib/python2.7/threading.py:524:__bootstrap
	/usr/lib/python2.7/threading.py:551:__bootstrap_inner
	/usr/lib/python2.7/threading.py:504:run
	--- <exception caught here> ---
	/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/threadpool.py:207:_worker
	/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:59:callWithContext
	/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/python/context.py:37:callWithContext
	/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/pool.py:112:thd
	/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/db/schedulers.py:165:thd
	/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1358:execute
	/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1491:_execute_clauseelement
	/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1599:_execute_context
	/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/base.py:1592:_execute_context
	/b/commit-queue/workdir/tools/build/third_party/sqlalchemy_0_7_1/sqlalchemy/engine/default.py:325:do_execute
	]]



Presubmit checks took 46.3s to calculate.

[Nico, 2013-10-24 02:36:54]

Committed patchset #2 manually as r230605.

[commit-bot: I haz the power, 2013-10-29 19:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/38873003/50001

[commit-bot: I haz the power, 2013-10-29 19:21:55]

Change committed as 231610