Issue 388703002: Introduce state to home card.

Issue 388703002: Introduce state to home card. (Closed)

Created:
6 years, 5 months ago by Jun Mukai

Modified:
6 years, 5 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Introduce state to home card. This is a preparation of crbug.com/387227. BUG=387227 R=oshima@chromium.org TEST=manually check for no regression Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282686

Patch Set 2 : fix #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -3 lines)			Patch
	M	athena/home/home_card_impl.cc	View	1	5 chunks	+17 lines, -3 lines	0 comments	Download
	M	athena/home/public/home_card.h	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm with nits https://codereview.chromium.org/388703002/diff/1/athena/home/public/home_card.h File athena/home/public/home_card.h (right): https://codereview.chromium.org/388703002/diff/1/athena/home/public/home_card.h#newcode28 athena/home/public/home_card.h:28: VISIBLE, how about VISIBLE_CENTERED VISIBLE_BOTTOM https://codereview.chromium.org/388703002/diff/1/athena/home/public/home_card.h#newcode42 ...

6 years, 5 months ago (2014-07-11 01:22:03 UTC) #2

Jun Mukai

https://codereview.chromium.org/388703002/diff/1/athena/home/public/home_card.h File athena/home/public/home_card.h (right): https://codereview.chromium.org/388703002/diff/1/athena/home/public/home_card.h#newcode28 athena/home/public/home_card.h:28: VISIBLE, On 2014/07/11 01:22:02, oshima wrote: > how about ...

6 years, 5 months ago (2014-07-11 18:18:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/388703002/20001

6 years, 5 months ago (2014-07-11 18:19:06 UTC) #5

Message was sent while issue was closed.

Change committed as 282686

Expand Messages | Collapse Messages