platform_tools/android/tests/generate_user_config_tests.py - Issue 388693003: Alphabetize defines in generated SkUserConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/tests/generate_user_config_tests.py

Issue 388693003: Alphabetize defines in generated SkUserConfig. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/tests/generate_user_config_tests.py

diff --git a/platform_tools/android/tests/generate_user_config_tests.py b/platform_tools/android/tests/generate_user_config_tests.py

index 660757d2bed421bcf6f3ef18cc691af0b830b4ef..a62bcecaaeee5d38cedafcfdb176585e93406bec 100644

--- a/platform_tools/android/tests/generate_user_config_tests.py

+++ b/platform_tools/android/tests/generate_user_config_tests.py

@@ -41,7 +41,7 @@ def generate_dummy_user_config(original_sk_user_config,

'bar' ]

gen_config(original_sk_user_config=original_sk_user_config,

require_sk_user_config=require_sk_user_config,

- target_dir=target_dir, ordered_set=defines)

+ target_dir=target_dir, defines=defines)

class GenUserConfigTest(unittest.TestCase):

@@ -58,7 +58,7 @@ class GenUserConfigTest(unittest.TestCase):

ordered_set = [ 'define' ]

mtklein 2014/07/14 16:29:22 -> defines?

scroggo 2014/07/14 17:06:52 Done.

gen_config(original_sk_user_config=original,

require_sk_user_config=True,

- target_dir=tmp, ordered_set=ordered_set)

+ target_dir=tmp, defines=ordered_set)

# With require_sk_user_config set to False, it is okay for

# original_sk_user_config to be missing.

« no previous file with comments | « platform_tools/android/tests/expectations/missing-filename.xxx ('k') | no next file » | no next file with comments »