Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 388683002: Switch OpenSSLClientKeyStore::ScopedEVP_PKEY to crypto::ScopedEVP_PKEY. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Switch OpenSSLClientKeyStore::ScopedEVP_PKEY to crypto::ScopedEVP_PKEY. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282684

Patch Set 1 #

Patch Set 2 : Mis-split CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -38 lines) Patch
M android_webview/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ssl/openssl_client_key_store.h View 3 chunks +2 lines, -9 lines 0 comments Download
M net/ssl/openssl_client_key_store.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M net/ssl/openssl_client_key_store_unittest.cc View 9 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
rsleevi: Main review and crypto/ OWNERS for DEPS rule benm: android_webview OWNERS sky: chrome/browser/ui OWNERS
6 years, 5 months ago (2014-07-10 23:58:31 UTC) #1
sgurun-gerrit only
On 2014/07/10 23:58:31, David Benjamin wrote: > rsleevi: Main review and crypto/ OWNERS for DEPS ...
6 years, 5 months ago (2014-07-11 00:50:22 UTC) #2
Ryan Sleevi
Good catch. LGTM (DEPS is fine because //net sits above //crypto)
6 years, 5 months ago (2014-07-11 01:00:34 UTC) #3
davidben
+msw for chrome/browser/ui/OWNERS. (Looks like sky is OOO today.)
6 years, 5 months ago (2014-07-11 14:03:33 UTC) #4
msw
c/b/ui lgtm
6 years, 5 months ago (2014-07-11 16:46:55 UTC) #5
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-11 16:48:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/388683002/20001
6 years, 5 months ago (2014-07-11 16:49:39 UTC) #7
sky
LGTM
6 years, 5 months ago (2014-07-11 17:11:53 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 18:10:54 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 20:26:39 UTC) #10
Message was sent while issue was closed. 
Change committed as 282684

Powered by Google App Engine
This is Rietveld 408576698