Added data reduction proxy holdback experiment

Added data reduction proxy holdback experiment

When this field trial is enabled and the data reduction proxy is
enabled, all UI elements will indicate that the proxy is enabled,
but the proxy will not be used.

BUG=357793, 394541
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283905

[bengr, 2014-07-10 23:03:54]

marq: all

[marq (ping after 24h), 2014-07-11 16:41:24]

LGTM with comment comments.

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
File components/data_reduction_proxy/browser/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.h:31: static
const unsigned int kHoldback = (1 << 4);
These flags should have some kind of comments.

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.h:52: //
experiment.
Define 'holdback experiment', for the benefit of someone reading the code in
nine months without the CL description for context.

[bengr, 2014-07-14 18:51:43]

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
File components/data_reduction_proxy/browser/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.h:31: static
const unsigned int kHoldback = (1 << 4);
On 2014/07/11 16:41:24, marq_ wrote:
> These flags should have some kind of comments.

Done.

https://codereview.chromium.org/388663002/diff/20001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.h:52: //
experiment.
On 2014/07/11 16:41:24, marq_ wrote:
> Define 'holdback experiment', for the benefit of someone reading the code in
> nine months without the CL description for context.

Done.

[bengr, 2014-07-16 23:31:37]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:39:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/388663002/140001

[commit-bot: I haz the power, 2014-07-17 01:34:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-17 01:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 01:41:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[bengr, 2014-07-17 17:46:55]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:50:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/388663002/160001

[commit-bot: I haz the power, 2014-07-17 22:22:15]

Change committed as 283905