Rotation into Video Layer + Content Transform

cc/layers/video_layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/video_layer.h"
 
 #include "cc/layers/video_layer_impl.h"
 
 namespace cc {
 
 scoped_refptr<VideoLayer> VideoLayer::Create(VideoFrameProvider* provider) {
   return make_scoped_refptr(new VideoLayer(provider));
 }
 
 VideoLayer::VideoLayer(VideoFrameProvider* provider) : provider_(provider) {

[scherkus (not reviewing), 2014/07/11 18:54:07]

initialize video_rotation_

   DCHECK(provider_);
 }
 
 VideoLayer::~VideoLayer() {}
 
 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
-  return VideoLayerImpl::Create(tree_impl, id(), provider_).PassAs<LayerImpl>();
+  scoped_ptr<VideoLayerImpl> impl =
+      VideoLayerImpl::Create(tree_impl, id(), provider_);
+  impl->set_video_rotation(video_rotation_);

[scherkus (not reviewing), 2014/07/11 18:54:07]

if this is the only way to create a VideoLayerImpl and we always set the
rotation ... I wonder whether it makes more sense to have video_rotation as part
of the ctor

I'll let danakj@ weigh in

[danakj, 2014/07/11 21:04:28]

This is the wrong place to do this, override PushPropertiesTo and do this set in
that place.

+  return impl.PassAs<LayerImpl>();
 }
 
 bool VideoLayer::Update(ResourceUpdateQueue* queue,
                         const OcclusionTracker<Layer>* occlusion) {
   bool updated = Layer::Update(queue, occlusion);
 
   // Video layer doesn't update any resources from the main thread side,
   // but repaint rects need to be sent to the VideoLayerImpl via commit.
   //
   // This is the inefficient legacy redraw path for videos.  It's better to
   // communicate this directly to the VideoLayerImpl.
   updated |= !update_rect_.IsEmpty();
 
   return updated;
 }
 
+void VideoLayer::set_video_rotation(media::VideoRotation video_rotation) {
+  video_rotation_ = video_rotation;
+}

[danakj, 2014/07/11 21:04:28]

This should call SetNeedsCommit();

+
 }  // namespace cc