Rotation into Video Layer + Content Transform

cc/layers/video_layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/video_layer.h"
 
 #include "cc/layers/video_layer_impl.h"
 
 namespace cc {
 
 scoped_refptr<VideoLayer> VideoLayer::Create(VideoFrameProvider* provider) {

[danakj, 2014/07/17 20:19:05]

Do we need to keep 2 Create methods?

-  return make_scoped_refptr(new VideoLayer(provider));
+  return make_scoped_refptr(new VideoLayer(provider, media::VIDEO_ROTATION_0));
 }
 
-VideoLayer::VideoLayer(VideoFrameProvider* provider) : provider_(provider) {
+scoped_refptr<VideoLayer> VideoLayer::Create(
+    VideoFrameProvider* provider,
+    media::VideoRotation video_rotation) {
+  return make_scoped_refptr(new VideoLayer(provider, video_rotation));
+}
+
+VideoLayer::VideoLayer(VideoFrameProvider* provider,
+                       media::VideoRotation video_rotation)
+    : provider_(provider), video_rotation_(video_rotation) {
   DCHECK(provider_);
 }
 
 VideoLayer::~VideoLayer() {}
 
 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
-  return VideoLayerImpl::Create(tree_impl, id(), provider_).PassAs<LayerImpl>();
+  scoped_ptr<VideoLayerImpl> impl =
+      VideoLayerImpl::Create(tree_impl, id(), provider_);

[danakj, 2014/07/17 20:19:05]

Sorry to backtrack, we don't normally have properties set once at construction
time and never change. Because this is one, you could pass it along here and get
rid of the PushProperties methods and the impl-side setter method. Your
instincts were right on that. Then we don't have to worry about testing damage
tracking things and such, and less code.

+  return impl.PassAs<LayerImpl>();
 }
 
 bool VideoLayer::Update(ResourceUpdateQueue* queue,
                         const OcclusionTracker<Layer>* occlusion) {
   bool updated = Layer::Update(queue, occlusion);
 
   // Video layer doesn't update any resources from the main thread side,
   // but repaint rects need to be sent to the VideoLayerImpl via commit.
   //
   // This is the inefficient legacy redraw path for videos.  It's better to
   // communicate this directly to the VideoLayerImpl.
   updated |= !update_rect_.IsEmpty();
 
   return updated;
 }
 
+void VideoLayer::PushPropertiesTo(LayerImpl* layer) {
+  Layer::PushPropertiesTo(layer);
+
+  VideoLayerImpl* other = static_cast<VideoLayerImpl*>(layer);
+  other->set_video_rotation(video_rotation_);
+}
+
 }  // namespace cc