aw: Add command switch to disable hardware acceleration

aw: Add switch to force auxiliary bitmap rendering

The switch will force use auxiliary bitmap path for all
rendering. This path is known to be slow.

This switch is temporary until Android L is released to AOSP.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282681

[sgurun-gerrit only, 2014-07-11 00:57:37]

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2181: }
Drive by: I think it is better to move the statics to AwContentsStatics.

[boliu, 2014-07-11 00:58:22]

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2181: }
On 2014/07/11 00:57:37, sgurun wrote:
> Drive by: I think it is better to move the statics to AwContentsStatics.

These are private though. I'd rather keep these closer to where it's used.

[sgurun-gerrit only, 2014-07-11 01:04:19]

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2181: }
yeah I can see that, but I think keeping state that impacts all awcontents in a
common location is also a good property. Do we have any other such statics in
this file? if no, I think you should consider not creating a precedence.

On 2014/07/11 00:58:22, boliu wrote:
> On 2014/07/11 00:57:37, sgurun wrote:
> > Drive by: I think it is better to move the statics to AwContentsStatics.
> 
> These are private though. I'd rather keep these closer to where it's used.

[boliu, 2014-07-11 01:09:02]

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2181: }
On 2014/07/11 01:04:18, sgurun wrote:
> yeah I can see that, but I think keeping state that impacts all awcontents in
a
> common location is also a good property. Do we have any other such statics in
> this file? if no, I think you should consider not creating a precedence.
> 
> On 2014/07/11 00:58:22, boliu wrote:
> > On 2014/07/11 00:57:37, sgurun wrote:
> > > Drive by: I think it is better to move the statics to AwContentsStatics.
> > 
> > These are private though. I'd rather keep these closer to where it's used.
> 

The state isn't really here though, it's in CommnandLine. The static vars are
just to make sure we don't call hasSwitch on every draw. This is the only
performance critical command line check in webview code. Ignacio added some
other switch check in java but those are not perf critical.

There's a few other static vars in AwContents, eg to avoid creating new java
objects etc, also for perf :)

[boliu, 2014-07-11 01:12:56]

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/388633003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2181: }
On 2014/07/11 01:09:02, boliu wrote:
> On 2014/07/11 01:04:18, sgurun wrote:
> > yeah I can see that, but I think keeping state that impacts all awcontents
in
> a
> > common location is also a good property. Do we have any other such statics
in
> > this file? if no, I think you should consider not creating a precedence.
> > 
> > On 2014/07/11 00:58:22, boliu wrote:
> > > On 2014/07/11 00:57:37, sgurun wrote:
> > > > Drive by: I think it is better to move the statics to AwContentsStatics.
> > > 
> > > These are private though. I'd rather keep these closer to where it's used.
> > 
> 
> The state isn't really here though, it's in CommnandLine. The static vars are
> just to make sure we don't call hasSwitch on every draw. This is the only
> performance critical command line check in webview code. Ignacio added some
> other switch check in java but those are not perf critical.
> 
> There's a few other static vars in AwContents, eg to avoid creating new java
> objects etc, also for perf :)

Added a comment

[sgurun-gerrit only, 2014-07-11 01:16:19]

lgtm

[hush (inactive), 2014-07-11 01:23:50]

lgtm

[boliu, 2014-07-11 01:24:57]

If you guys followed the internal bug, you'll see that I'm not trying to submit
this yet :p

[sgurun-gerrit only, 2014-07-11 01:26:46]

On 2014/07/11 01:24:57, boliu wrote:
> If you guys followed the internal bug, you'll see that I'm not trying to
submit
> this yet :p

should I interpret this as a request to remove the LGTM :)

[boliu, 2014-07-11 01:28:43]

On 2014/07/11 01:26:46, sgurun wrote:
> On 2014/07/11 01:24:57, boliu wrote:
> > If you guys followed the internal bug, you'll see that I'm not trying to
> submit
> > this yet :p
> 
> should I interpret this as a request to remove the LGTM :)

I don't think there is a way to set yourself back to 0. If you say the magic
phrase n-o-t l-g-t-m, I think it's interpreted the same way as a -2 in gerrit.
And I definitely don't want that

[boliu, 2014-07-11 16:11:25]

Ok, rewrote the whole thing to skip digging out skpicture as well. Now this is
tested and works

[hush (inactive), 2014-07-11 17:24:17]

On 2014/07/11 16:11:25, boliu wrote:
> Ok, rewrote the whole thing to skip digging out skpicture as well. Now this is
> tested and works

lgtm

[boliu, 2014-07-11 17:25:35]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-07-11 17:26:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/388633003/40001

[commit-bot: I haz the power, 2014-07-11 20:10:34]

Change committed as 282681