Issue 388583003: Indicate incognito in Service Worker and IndexedDB internals pages

Issue 388583003: Indicate incognito in Service Worker and IndexedDB internals pages (Closed)

Created:
6 years, 5 months ago by jsbell

Modified:
6 years, 5 months ago

Reviewers:
michaeln

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, jam, serviceworker-reviews, alecflett, kinuko+serviceworker, ericu+idb_chromium.org, darin-cc_chromium.org, nhiroki, cmumford, horo+watch_chromium.org, dgrogan, jsbell+idb_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Indicate incognito in Service Worker and IndexedDB internals pages Both internals pages were displaying the partition path, which is bogus when in Incognito mode - both just store everything in memory. Track and pass the state along from context -> internals helper -> JS -> HTML and show a label instead. (Screenshots in the bug.) BUG=388168 R=michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282460

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -17 lines)			Patch
M	content/browser/indexed_db/indexed_db_context_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_context_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_internals_ui.cc	View	1 chunk	+12 lines, -8 lines	0 comments	Download
M	content/browser/resources/indexed_db/indexeddb_internals.html	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	content/browser/resources/service_worker/serviceworker_internals.html	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	content/browser/service_worker/service_worker_context_wrapper.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/browser/service_worker/service_worker_context_wrapper.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_internals_ui.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/388583003/1

6 years, 5 months ago (2014-07-10 22:50:47 UTC) #4

Message was sent while issue was closed.

Change committed as 282460

Expand Messages | Collapse Messages