Issue 388583002: Remove RenderViewObserver::ZoomLevelChanged.

Issue 388583002: Remove RenderViewObserver::ZoomLevelChanged. (Closed)

Created:
6 years, 5 months ago by wjmaclean

Modified:
6 years, 5 months ago

Reviewers:
brettw, Ilya Sherman

CC:
chromium-reviews, creis+watch_chromium.org, benquan, jam, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove RenderViewObserver::ZoomLevelChanged. This pathway is obsolete, and is removed in this CL. BUG=392851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282738

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -11 lines)			Patch
M	components/autofill/content/renderer/autofill_agent.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/public/renderer/render_view_observer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+0 lines, -2 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

wjmaclean

This is a very small change, removing an obsolete pathway. Would you please take a ...

6 years, 5 months ago (2014-07-11 16:59:15 UTC) #1

Ilya Sherman

LGTM. Thanks for the cleanup! https://codereview.chromium.org/388583002/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/388583002/diff/1/content/renderer/render_view_impl.cc#newcode3943 content/renderer/render_view_impl.cc:3943: void RenderViewImpl::zoomLevelChanged() { Just ...

6 years, 5 months ago (2014-07-11 19:19:44 UTC) #2

wjmaclean

On 2014/07/11 19:19:44, Ilya Sherman wrote: > LGTM. Thanks for the cleanup! > > https://codereview.chromium.org/388583002/diff/1/content/renderer/render_view_impl.cc ...

6 years, 5 months ago (2014-07-11 19:29:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/388583002/1

6 years, 5 months ago (2014-07-11 21:01:53 UTC) #6

Message was sent while issue was closed.

Change committed as 282738

Expand Messages | Collapse Messages