Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 388573004: Revert of WebGL: Refactor active context management. (Closed)

Created:
6 years, 5 months ago by ccameron
Modified:
6 years, 5 months ago
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of WebGL: Refactor active context management. (https://codereview.chromium.org/251373005/) Reason for revert: This is likely to be the cause of crashes observed in http://build.chromium.org/p/chromium.gpu/builders/Mac%20Debug%20%28Intel%29/builds/34596 Original issue's description: > WebGL: Refactor active context management. > > This CL makes WebGL lost&retore code more succinct. > > 1. Deactive a context in loseContextImpl(), instead of dispatchContextLostEvent(). > Because of > a) Prevent inconsistent state. Currently, activeContext() vector can store a lost > context due to this, so oldestContextIndex() needs to check if active context is > lost. Now we don't need redundant lostContext check. In addition, it does not > make sense that active context list can store a lost context. > b) In the same sense, only maybeRestoreContext() actives a context like loseContextImpl() > in this CL. > > 2. Don't call activeContexts().remove() adhoc. > Only deactiveContext() calls activeContexts().remove() like only activeContext() > calls activeContexts().append(). > > 3. Change the logic of dispatchContextLostEvent(). > Currently, when m_contextLostMode != RealLostContext, a context is added to > forcibly evicted list, in which the context will be restored when another > context is destructed. However, we start the restore-timer when > the context is lost due to AutoRecoverSyntheticLostContext also. It means > AutoRecoverSyntheticLostContext can restore twice. So this CL changes a context > to be added into forcibly evicted list only if SyntheticLostContext. > > BUG=392274 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 6 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
Created Revert of WebGL: Refactor active context management.
6 years, 5 months ago (2014-07-10 19:26:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/388573004/1
6 years, 5 months ago (2014-07-10 19:27:14 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 19:27:15 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-10 19:27:16 UTC) #4
dshwang
6 years, 5 months ago (2014-07-10 19:55:59 UTC) #5
Message was sent while issue was closed.
Thank you for reporting.
This CL is already reverted by kbr@, https://codereview.chromium.org/382893002

Powered by Google App Engine
This is Rietveld 408576698