Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 388563005: Add a ref counted audio bus. (Closed)

Created:
6 years, 5 months ago by rkc
Modified:
6 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add a ref counted audio bus. For some applications where we need to keep multiple copies of the audio bus around (particularly in STL containers), a scoped_ptr to an audio bus isn't enough. For those rare situations, we're adding a RefCounted version of the AudioBus. R=dalecurtis@chromium.org BUG=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282510

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M media/base/audio_bus.h View 1 2 3 chunks +21 lines, -1 line 0 comments Download
M media/base/audio_bus.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rkc
6 years, 5 months ago (2014-07-10 20:44:51 UTC) #1
DaleCurtis
lgtm
6 years, 5 months ago (2014-07-10 21:41:57 UTC) #2
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 5 months ago (2014-07-10 21:44:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/388563005/40001
6 years, 5 months ago (2014-07-10 21:47:15 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 02:53:22 UTC) #5
Message was sent while issue was closed.
Change committed as 282510

Powered by Google App Engine
This is Rietveld 408576698