Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 388563004: Fix syncing of system theme on Linux (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
Reviewers:
haitaol1, pkotwicz, erg
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, Elliot Glaysher
Project:
chromium
Visibility:
Public.

Description

Fix syncing of system theme on Linux Makes the "IsSystemThemeDistinctFromDefaultTheme()" detection logic compatible with non-GTK (ie. Aura) Linux. It moves the check out of sync code and into the ThemeService so this kind of bug will be less likely to recur if the themes logic changes again. Re-enables an integration test that was disabled during the transition to Aura. BUG=304554, 392934 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/sync/test/integration/two_client_themes_sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service.cc View 3 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rlarocque
haitaol: Please review theme_syncable_service.cc and two_client_themes_sync_test.cc pkotwicz: Please review chrome/browser/themes/*
6 years, 5 months ago (2014-07-10 20:48:07 UTC) #1
erg
(fwiw, lgtm, and thank you for tracking this down.)
6 years, 5 months ago (2014-07-10 21:14:38 UTC) #2
haitaol1
lgtm
6 years, 5 months ago (2014-07-10 21:18:13 UTC) #3
pkotwicz
LGTM. Thanks for fixing this!
6 years, 5 months ago (2014-07-10 21:25:46 UTC) #4
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-10 21:26:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/388563004/1
6 years, 5 months ago (2014-07-10 21:27:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 22:50:24 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:20:14 UTC) #8
Message was sent while issue was closed.
Change committed as 282491

Powered by Google App Engine
This is Rietveld 408576698