Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 388563003: Merge 176880 "Properly repaint RenderLayer's descendants when it..." (Closed)

Created:
6 years, 5 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Merge 176880 "Properly repaint RenderLayer's descendants when it..." > Properly repaint RenderLayer's descendants when it moves > > When a RenderLayer moves, it can cause non-composited descendants of itself > that are placed relatively to it to need to be repainted. These descandants > may not have needed layout themselves, nor have they moved as far as the > RenderLayer itself is concerned. This patch forces all descendant RenderLayers > of a moved ancestor to at a minimum be checked by invalidateTreeAfterLayout > to see if they need to be repainted. > > Ideally we'd bail in markDescendantLayersMayNeedPaintInvalidation when > we hit a composited layer, but because updateLayerPositions occurs before > compositing update, this would be a chicken and egg problem. > > BUG=385103 > > Review URL: https://codereview.chromium.org/354613003 TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, --2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/repaint-descandant-on-ancestor-layer-move.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/repaint/repaint-descandant-on-ancestor-layer-move-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
leviw_travelin_and_unemployed
6 years, 5 months ago (2014-07-10 18:32:14 UTC) #1
leviw_travelin_and_unemployed
6 years, 5 months ago (2014-07-10 18:32:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r177867.

Powered by Google App Engine
This is Rietveld 408576698