Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 388503002: Split SkTRacy into SkTRacy and SkTRacyReffable. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Split SkTRacy into SkTRacy and SkTRacyReffable. Looks like TSAN can't always suppress our existing implementation of SkTRacy (what is turning here into SkTRacyReffable). To minimize flakiness, use SkTRacy where possible and SkTRacyReffable where necessary. BUG=skia: Committed: https://skia.googlesource.com/skia/+/497cda3a6b72b9cb390334e8756d38b4ffac044f NOTRY=true Committed: https://skia.googlesource.com/skia/+/42483d902634f6bfc65dbd8bc999610faf372ef0

Patch Set 1 #

Patch Set 2 : write doesn't return anything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkDynamicAnnotations.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mtklein
Not sure how best to do the forced-caching yet, so let's land the soft- and ...
6 years, 5 months ago (2014-07-10 15:55:16 UTC) #1
robertphillips
lgtm
6 years, 5 months ago (2014-07-10 15:59:44 UTC) #2
mtklein
+reed for include/
6 years, 5 months ago (2014-07-10 16:03:38 UTC) #3
reed1
lgtm
6 years, 5 months ago (2014-07-10 17:20:41 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 17:21:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/388503002/1
6 years, 5 months ago (2014-07-10 17:22:21 UTC) #6
commit-bot: I haz the power
Change committed as 497cda3a6b72b9cb390334e8756d38b4ffac044f
6 years, 5 months ago (2014-07-10 17:38:30 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 17:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/388503002/20001
6 years, 5 months ago (2014-07-10 17:52:40 UTC) #9
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-10 18:11:39 UTC) #10
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 18:11:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/388503002/20001
6 years, 5 months ago (2014-07-10 18:11:46 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 18:12:03 UTC) #13
Message was sent while issue was closed.
Change committed as 42483d902634f6bfc65dbd8bc999610faf372ef0

Powered by Google App Engine
This is Rietveld 408576698