Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 388493002: Revert 282307 "Map WebSocket URL schemes to HTTP URL schemes for..." (Closed)

Created:
6 years, 5 months ago by kaliamoorthi
Modified:
6 years, 5 months ago
Reviewers:
Adam Rice
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282307 "Map WebSocket URL schemes to HTTP URL schemes for..." > Map WebSocket URL schemes to HTTP URL schemes for auth purposes. > > This permits WebSocket connections to inherit credentials from HTTP pages, and > matches the behaviour of other browsers. > > Design doc: https://docs.google.com/a/chromium.org/document/d/129rLtf5x3hvhP5rayLiSxnEjOXS8Z7EnLJgBL4CdwjI/edit > > Also consider any 401 or 407 results that reach the WebSocketStream > URLRequest::Delegate to be unrecoverable errors. > > Also ensure that the response headers are reported back to the renderer > when the developer tools are open and a 401 error happens. > > BUG=123862 > > Review URL: https://codereview.chromium.org/336263005 Seems to cause WebSocket1 failure in WinXP TBR=ricea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -554 lines) Patch
M trunk/src/chrome/browser/net/websocket_browsertest.cc View 3 chunks +23 lines, -199 lines 0 comments Download
M trunk/src/net/data/websocket/README View 1 chunk +0 lines, -5 lines 0 comments Download
D trunk/src/net/data/websocket/connect_to.html View 1 chunk +0 lines, -34 lines 0 comments Download
M trunk/src/net/http/http_network_transaction.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/net/test/spawned_test_server/base_test_server.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/net/test/spawned_test_server/base_test_server.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M trunk/src/net/tools/testserver/testserver.py View 3 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M trunk/src/net/websockets/websocket_stream.h View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/net/websockets/websocket_stream.cc View 4 chunks +1 line, -38 lines 0 comments Download
M trunk/src/net/websockets/websocket_stream_test.cc View 12 chunks +23 lines, -226 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kaliamoorthi
6 years, 5 months ago (2014-07-10 15:18:33 UTC) #1
kaliamoorthi
6 years, 5 months ago (2014-07-10 15:18:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r282331 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698