Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 388463002: Oilpan: fix build after r177815 (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rely on implicit conversions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M Source/platform/CrossThreadCopier.h View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
haraken
Thanks for the quick fix. LGTM. https://codereview.chromium.org/388463002/diff/1/Source/platform/CrossThreadCopier.h File Source/platform/CrossThreadCopier.h (right): https://codereview.chromium.org/388463002/diff/1/Source/platform/CrossThreadCopier.h#newcode167 Source/platform/CrossThreadCopier.h:167: return ptr.get(); Do ...
6 years, 5 months ago (2014-07-10 12:01:46 UTC) #1
sof
https://codereview.chromium.org/388463002/diff/1/Source/platform/CrossThreadCopier.h File Source/platform/CrossThreadCopier.h (right): https://codereview.chromium.org/388463002/diff/1/Source/platform/CrossThreadCopier.h#newcode167 Source/platform/CrossThreadCopier.h:167: return ptr.get(); On 2014/07/10 12:01:45, haraken wrote: > > ...
6 years, 5 months ago (2014-07-10 12:05:04 UTC) #2
sof
Landing this, but without a NOTRY. I don't have the mettle :)
6 years, 5 months ago (2014-07-10 12:33:55 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-10 12:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/388463002/20001
6 years, 5 months ago (2014-07-10 12:34:59 UTC) #5
sof
Needs Source/platform/ approval - tkent, jochen ? :)
6 years, 5 months ago (2014-07-10 12:57:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-07-10 13:27:05 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 13:28:13 UTC) #8
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-10 13:29:09 UTC) #9
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-10 13:29:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/388463002/20001
6 years, 5 months ago (2014-07-10 13:29:45 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 13:30:37 UTC) #12
Message was sent while issue was closed.
Change committed as 177829

Powered by Google App Engine
This is Rietveld 408576698