Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 388393002: Add ui/views to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, tdresser+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -578 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_events_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ui/views/BUILD.gn View 1 2 1 chunk +259 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 11 chunks +594 lines, -578 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-15 00:01:42 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-15 04:32:06 UTC) #2
brettw
6 years, 5 months ago (2014-07-16 00:08:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r283292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698