Reject reasons from strike register when nonce validation fails.

Reject reasons from strike register when nonce validation fails.

Send reject reason to client for debugging purposes.

Merge internal change: 70366491

R=wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283692

[wtc, 2014-07-14 21:52:29]

Patch set 1 LGTM.

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/local_strike...
File net/quic/crypto/local_strike_register_client.cc (right):

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/local_strike...
net/quic/crypto/local_strike_register_client.cc:47: cb->Run((nonce_error ==
net::NONCE_OK), nonce_error);

Remove net::

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_server_config.cc:1494: case NONCE_OK:

This case cannot happen because of the check and early return on lines
1484-1486.

It would be clearer to merge lines 1484-1486 into the switch statement, as the
first case:

  case NONCE_OK:
    return HANDSHAKE_OK;

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_server_config.cc:1503: return
SERVER_NONCE_NOT_UNIQUE_FAILURE;

Because of the "default" case in the switch statement, this line is unreachable.
It should be deleted.

[ramant (doing other things), 2014-07-14 22:16:06]

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/local_strike...
File net/quic/crypto/local_strike_register_client.cc (right):

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/local_strike...
net/quic/crypto/local_strike_register_client.cc:47: cb->Run((nonce_error ==
net::NONCE_OK), nonce_error);
On 2014/07/14 21:52:28, wtc wrote:
> 
> Remove net::

Done.

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_server_config.cc:1494: case NONCE_OK:
On 2014/07/14 21:52:28, wtc wrote:
> 
> This case cannot happen because of the check and early return on lines
> 1484-1486.
> 
> It would be clearer to merge lines 1484-1486 into the switch statement, as the
> first case:
> 
>   case NONCE_OK:
>     return HANDSHAKE_OK;

Thanks much.
Done.

https://codereview.chromium.org/388333005/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_server_config.cc:1503: return
SERVER_NONCE_NOT_UNIQUE_FAILURE;
On 2014/07/14 21:52:28, wtc wrote:
> 
> Because of the "default" case in the switch statement, this line is
unreachable.
> It should be deleted.

Done.

[wtc, 2014-07-14 22:19:24]

Patch set 2 LGTM.

[ramant (doing other things), 2014-07-16 18:45:56]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-07-16 18:47:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/388333005/40001

[commit-bot: I haz the power, 2014-07-16 22:37:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 23:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:03:45]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[ramant (doing other things), 2014-07-16 23:26:51]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:29:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/388333005/40001

[commit-bot: I haz the power, 2014-07-17 07:34:25]

Change committed as 283692